Skip to content

feat:TAP-11093 Aggregation node optimization #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarad0628 merged 1 commit into from
Apr 24, 2026
Merged

feat:TAP-11093 Aggregation node optimization #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...ors/mongodb-connector/src/main/java/io/tapdata/mongodb/MongodbExecuteCommandFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,8 @@ private AggregateIterable<Document> getAggregateIterable(Map<String, Object> exe
ExecuteObject executeObject = new ExecuteObject(executeObj);
String database = executeObject.getDatabase();
String collection = executeObject.getCollection();
if (collection == null || collection.isEmpty()) {
throw new RuntimeException(String.format("Process execute %s failed, collection name cannot be blank", executeObject));
}
List<Document> pipelines = executeObject.getPipeline();
if (pipelines.isEmpty()) {
if (pipelines == null || pipelines.isEmpty()) {
throw new RuntimeException(String.format("Process execute %s failed, pipeline cannot be blank", executeObject));
}
boolean allowDiskUse = true;
Expand All @@ -189,7 +186,11 @@ private AggregateIterable<Document> getAggregateIterable(Map<String, Object> exe
// ignored
}

return mongoClient.getDatabase(database).getCollection(collection).aggregate(pipelines).allowDiskUse(allowDiskUse);
MongoDatabase mongoDatabase = mongoClient.getDatabase(database);
if (collection == null || collection.isEmpty()) {
return mongoDatabase.aggregate(pipelines).allowDiskUse(allowDiskUse);
}
return mongoDatabase.getCollection(collection).aggregate(pipelines).allowDiskUse(allowDiskUse);
}

public Object aggregate(Map<String, Object> executeObj, MongoClient mongoClient) {
Expand Down