fix:TAP-11425 Rebuilding cache keeps showing as running.#3183
fix:TAP-11425 Rebuilding cache keeps showing as running.#3183weiliang110100 wants to merge 1 commit intodevelopfrom
Conversation
🤖 Augment PR SummarySummary: Adjusts merge-table cache rebuild execution so rebuild flows don’t appear to run indefinitely.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| } | ||
|
|
||
| protected void doSnapshotWithControl(List<String> tableList) throws Throwable { | ||
| protected void doSnapshotWithControl(List<String> tableList,boolean needRun) throws Throwable { |
There was a problem hiding this comment.
needRun is currently ignored for the isSourceAndTarget() fast-path, so doSnapshot(tableList) will still execute even when needRun is false (HazelcastSourcePdkDataNode.java:430). This could trigger an unexpected snapshot when the task is reFullRun but this node/table isn’t meant to rebuild cache.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| // Verify | ||
| verify(sourceNode, times(1)).doSnapshotWithControl(anyList()); | ||
| verify(sourceNode, times(1)).doSnapshotWithControl(anyList(),anyBoolean()); |
There was a problem hiding this comment.
This test now verifies doSnapshotWithControl(..., anyBoolean()), but it doesn’t assert the needRun value, so regressions in the rebuild/skip branching may slip through (HazelcastSourcePdkDataNodeTest.java:4082). Consider adding coverage for the isReFullRunTask()==true + checkRebuildMergeTableCache(true)==false path where needRun should be false.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
1 participant
No description provided.