refactor(testcontainers): extract ObjectMapper to static field in tdg.Utils#96
Merged
Merged
Conversation
….Utils ObjectMapper instances are thread-safe after configuration and can be safely reused. Hoisting the instance to a static final field removes the duplicated `new ObjectMapper()` allocations in sendUsers() and getUsers() and avoids creating a fresh mapper (and re-reading its configuration) on every call. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
bitgorbovsky
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist the
ObjectMapperinstance used by the test helperorg.testcontainers.containers.tdg.Utilsfrom a method-local variable toa
static finalfield.ObjectMapperinstances are thread-safe once configured, so the previousnew ObjectMapper()allocations insendUsers(List<User>, TDGContainer<?>)and
getUsers(int, TDGContainer<?>)were unnecessary and duplicated.Extracting the instance:
new ObjectMapper()call sites;
OBJECT_MAPPER),matching the UPPER_SNAKE_CASE convention for
static finalfields;one-line change in a single spot instead of two.
This is a test-only refactor —
Utilslives undersrc/test/javaand isnot part of the published artifact, so there is no API or behavior change
for SDK consumers.
I haven't forgotten about: