Add full job description pages for each open career role#52
Merged
Conversation
The "Open roles" grid on /careers.html listed six roles (title + location only) that all linked to /contact.html - no actual description of the work, responsibilities, or requirements existed anywhere on the site. Added a dedicated detail page per role (career-*.html), each with: - a role summary - three "what you'll do" responsibility panels - four "what you'll bring" requirement tiles (must-have vs preferred) - links to the other open roles - an apply CTA Follows the same generator pattern already used for service and case-study detail pages (CAREER_ROLES data list -> career_detail_main template -> STUB_PAGES registration), so the new pages are picked up automatically by the search index and sitemap generation with no separate wiring. The careers.html role tiles now link to their real detail pages instead of /contact.html. Verified: build runs clean and is scoped to exactly the intended files (careers.html, six new career-*.html pages, search-index.json, sitemap.xml - no unrelated churn), and the CI link-checker's internal-link scan passes with zero missing links. Signed-off-by: chellej <197998703+chellej@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/careers.htmllisted six roles (title + location only), all linking to/contact.html- there was no page anywhere describing the actual work, responsibilities, or requirements for any of them.CAREER_ROLESdata list ->career_detail_main()template ->STUB_PAGESregistration), so the pages are picked up automatically by search-index and sitemap generation - no separate wiring needed.careers.html's role tiles now link to their real detail pages instead of/contact.html.Test plan
python3 -m py_compile scripts/generate-site.pypython3 scripts/generate-site.py- clean run, writes the 6 new pages pluscareers.html,search-index.json,sitemap.xmlmaster)site/- 0 missing linkscareer-data-engineer.html) for correct markup and no duplicated copy between hero and body