fix(sql): decode MySQL BINARY/VARBINARY columns#3444
Open
rumitvn wants to merge 1 commit into
Open
Conversation
MySQL reports VARCHAR columns with a binary collation (e.g. utf8mb4_bin)
as VARBINARY, which fell through to the unsupported-datatype error
("unsupported datatype: VARBINARY"). Add BINARY and VARBINARY to the
binary-decoding arm so they are returned as byte arrays like the other
binary types. Also fix a typo (TINIYBLOB) that prevented TINYBLOB
columns from being decoded.
Closes tauri-apps#2274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2274.
MySQL reports
VARCHARcolumns that use a binary collation (e.g.utf8mb4_bin) asVARBINARY. The MySQL decoder didn't handleBINARY/VARBINARY, so those columns fell through to the catch-all and failed with:(reported by several users, and the underlying behavior also tracked in launchbadge/sqlx#3387).
Changes
BINARYandVARBINARYto the binary-decoding match arm inplugins/sql/src/decode/mysql.rs, so they are returned as byte arrays just likeBLOB/TINYBLOB/etc. This fixes the error without downgradingsqlx.TINIYBLOB→TINYBLOB, which meantTINYBLOBcolumns were never matched and silently fell through too.cargo check -p tauri-plugin-sql --features mysqlpasses. Added a covector changefile (sql/sql-jspatch).