You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since unsigned char can be used interchangeably with uint8_t, I’ve updated the code to first replace all instances of unsigned char with uint8_t within the extractFont function. This ensures compatibility with both types.
Since unsigned char is a fundamental type and tends to integrate more smoothly with legacy code, I’ve chosen to use unsigned char instead of uint8_t in the Process and Create File section.
I understand the idea, but technically, unsigned char is not guaranteed to be an 8-bit type, while uint8_t is (if available), right? So I'd be inclined to use uint8_t for exporting (what is done already); what legacy code did you encounter where this was posing a problem?
I’ve come across some cases where unsigned char is used instead of uint8_t, which is why I included support for it. I understand that char isn’t guaranteed to be exactly one byte, even though it almost always is in practice. That said, I figured you might choose not to include it, since most of the existing .h files already use uint8_t consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since unsigned char can be used interchangeably with uint8_t, I’ve updated the code to first replace all instances of unsigned char with uint8_t within the extractFont function. This ensures compatibility with both types.
Since unsigned char is a fundamental type and tends to integrate more smoothly with legacy code, I’ve chosen to use unsigned char instead of uint8_t in the Process and Create File section.