Conversation
|
Did you use LDView's OBI code for the high-contrast work? (I'm guessing not, since it requires modified parts.) The OBI code was added years ago, but never became mainstream due to the requirement of having updated parts. |
I did not. The high-contrast behaviour simply extends the primitives in TCStudLogoPrimitive StudLogoPrimitives and adds the ability to manipulate the stud cylinder and edge line colour both manually and automatically. The resulting behaviour adds an 'automate edge line color' checkbox to the Geometry tab and two new options to the Primitives tab's 'use stud logo geometry' combo control: HighContrast =6 High Contrast Plain
HighContrastSingleWire =7 High Contrast Single WireCheers, |
|
I've added the full feature set which includes preference options to manually configure high-contrast studs and edge lines along with the preference to automatically adjust edge line color. The automate edge line color preference is set under the Geometry tab while use stud geometry is under Primitives. 
Example model file. Details0 FILE StudStyles.ldr
0 Stud Styles
0 Name: studStyles.ldr
0 Author: LPub3D
0 !LICENSE Not redistributable : see NonCAreadme.txt
1 4 0 0 0 1 0 0 0 1 0 0 0 1 3001.dat
1 4 -40 24 0 1 0 0 0 1 0 0 0 1 3001.dat
1 4 40 24 0 1 0 0 0 1 0 0 0 1 3001.dat
0 ROTSTEP END
1 4 80 0 0 1 0 0 0 1 0 0 0 1 3001.dat
1 4 120 24 0 1 0 0 0 1 0 0 0 1 3001.dat
1 15 40 -24 0 1 0 0 0 1 0 0 0 1 3001.dat
0 STEP
1 1 -20 -8 0 1 0 0 0 1 0 0 0 1 subModel-1.ldr
0 STEP
1 15 -60 16 0 1 0 0 0 1 0 0 0 1 subModel-2.ldr
0 ROTSTEP 0 270 0 REL
1 0 100 -8 0 1 0 0 0 1 0 0 0 1 subModel-2.ldr
0 ROTSTEP 0 180 0 REL
1 1 140 16 0 1 0 0 0 1 0 0 0 1 subModel-1.ldr
1 15 40 -64 10 1 0 0 0 1 0 0 0 1 67329.dat
1 71 30 -88 10 1 0 0 0 1 0 0 0 1 15411.dat
1 288 50 -88 10 1 0 0 0 1 0 0 0 1 4070.dat
0 ROTSTEP 0 90 0 REL
0 NOFILE
0 FILE submodel-1.ldr
0
0 Name: subModel-1.ldr
0 Author: LPub3D
0 !LICENSE Not redistributable : see NonCAreadme.txt
1 1 0 0 0 1 0 0 0 1 0 0 0 1 87580.dat
0 ROTSTEP END
1 14 0 -24 0 1 0 0 0 1 0 0 0 1 3062b.dat
0 STEP
0 NOFILE
0 FILE submodel-2.ldr
0
0 Name: subModel-2.ldr
0 Author: LPub3D
0 !LICENSE Not redistributable : see NonCAreadme.txt
1 0 0 0 0 1 0 0 0 1 0 0 0 1 87580.dat
0 ROTSTEP END
1 25 0 -24 0 1 0 0 0 1 0 0 0 1 3062a.dat
0 STEP
0 NOFILECheers, |
|
@pbartfai Do we want to update this PR to support macOS and Qt before releasing 4.7 or after? (Qt for you, macOS for me.) |
Let's release 4.7 first. |
|
Great. I'll do the macOS one. Do you know what the best way is to handle
this? I think it's probably easiest to just merge Trevor's Windows-only PR
to our master and then create new PRs for Qt and macOS.
Note: I have not yet reviewed Trevor's PR, but I will do that. Can you
include a Qt screenshot in your PR description? I'll do one for macOS once
I have it implemented.
…--Travis
On Tue, Mar 17, 2026 at 4:08 PM Peter Bartfai ***@***.***> wrote:
*pbartfai* left a comment (tcobbs/ldview#101)
<#101 (comment)>
@pbartfai <https://github.com/pbartfai> Do we want to update this PR to
support macOS and Qt before releasing 4.7 or after? (Qt for you, macOS for
me.)
Let's release 4.7 first.
@tcobbs <https://github.com/tcobbs> 4.7 has been released
I've prepared the Qt UI...
—
Reply to this email directly, view it on GitHub
<#101 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4BDKKQDDTTMILLWC6KEQL4RHEHBAVCNFSM6AAAAACKWOSG3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANZYGI3TMMBUGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@trevorsandy Sorry for the delay. I am finally ready to review this and hopefully merge, but I have hit some possible problems. I'm guessing that this PR includes all of the local changes that you have made to LDView for LPub3d, because there is a bunch of stuff in here that is totally unrelated to the stud logo settings the that PR title makes this seem to be. (You do state in the description that this includes high-contrast studs and edge lines, and maybe that's all that's here in addition to the stud logos.) While I don't have a problem in principle of incorporating all of these changes, I would greatly prefer if they didn't all show up in one single PR. (Having said that, I am not saying that separate PRs is an absolute requirement.) How hard would it be to narrow down this PR to just the stud logo changes, and then create one or two other PRs for the other changes? I promise that I will deal with them in a timely manner. Finally, can you confirm that this PR only contains the following:
|
|
After starting to review the PR, I realized that it has two (maybe three)
unrelated features. I asked Trevor if he would be willing to split it into
multiple PRs. I'll see what he says.
…--Travis
On Tue, Mar 17, 2026 at 7:19 PM Travis Cobbs ***@***.***> wrote:
Great. I'll do the macOS one. Do you know what the best way is to handle
this? I think it's probably easiest to just merge Trevor's Windows-only PR
to our master and then create new PRs for Qt and macOS.
Note: I have not yet reviewed Trevor's PR, but I will do that. Can you
include a Qt screenshot in your PR description? I'll do one for macOS once
I have it implemented.
--Travis
On Tue, Mar 17, 2026 at 4:08 PM Peter Bartfai ***@***.***>
wrote:
> *pbartfai* left a comment (tcobbs/ldview#101)
> <#101 (comment)>
>
> @pbartfai <https://github.com/pbartfai> Do we want to update this PR to
> support macOS and Qt before releasing 4.7 or after? (Qt for you, macOS for
> me.)
>
> Let's release 4.7 first.
>
> @tcobbs <https://github.com/tcobbs> 4.7 has been released
> I've prepared the Qt UI...
>
> —
> Reply to this email directly, view it on GitHub
> <#101 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE4BDKKQDDTTMILLWC6KEQL4RHEHBAVCNFSM6AAAAACKWOSG3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANZYGI3TMMBUGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
3 participants
Enable the ability to select stud logo preference using the following stud logo geometry:
0 Plain
1 Single Wire
2 Double Wire
3 Raised Flat
4 Raised Rounded
5 Subtle Rounded
Only the Windows GUI is implemented; however from other platforms (i.e. macOS/Linux), you can set the the following options using [Sessions] in your .ini file.
This feature is a subset of the comprehensive behaviour which also includes high-contrast studs and edge lines.
With the addition of high-contrast studs and automatic edge line colors, the stud style ini file options have changed to:
And stud geometry options are extended to:
0 Plain
1 Single Wire
2 Double Wire
3 Raised Flat
4 Raised Rounded
5 Subtle Rounded
6 High Contrast Plain
7 High Contrast Single Wire
Cheers,