Add unit tests for MetricCalculatorLogic command building#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MetricCalculatorLogicbuilds correct CLI commands for different metric types and flag combinations.qtandslicer).Description
localizer/src/tests/test_ui_metric_command_builder.pywhich injectslocalizer/libonsys.pathand provides a_load_metric_calculator_logichelper that stubsqtandslicerbefore importingMetricCalculatorLogic.test_build_command_uses_subcommand_cli_for_centaurto assert thecentaursubcommand, presence of--input/--output, and handling of--manual-fovand--skip-normalization.test_build_command_fillstates_requires_tracer_and_no_suvrandtest_build_suvr_command_does_not_reference_legacy_flagto validate tracer handling forFill Statesand thatsuvrcommands do not reference legacy flags.Testing
pytest localizer/src/tests/test_ui_metric_command_builder.pyand the tests completed successfully.Codex Task