Fix ONNX path conversion for non-Windows builds#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
makeOrtPathwhich on macOS/Linux produced abasic_string<wchar_t>->basic_string<char>return-type mismatch and broke compilation.Description
localizer/src/core/common/OnnxPath.hsomakeOrtPathdoesCommon::path::utf8ToWide(preparedPath)only inside the Windows (_WIN32) branch whenORTCHAR_Tiswchar_t, and returnpreparedPathdirectly on non-Windows platforms to preserve correct return types.Testing
localizer/srcto validate the change, but the run stopped because the environment is missingITK(ITKConfig.cmake) and a LFS pointer file (localizer/Testing/ED01_PET.nii), so a full build could not be completed. No automated unit tests were executed.Codex Task