Conversation
jacksonmowry
approved these changes
Mar 3, 2026
Collaborator
jacksonmowry
left a comment
There was a problem hiding this comment.
Sweet! Thank you so much
acandershock
approved these changes
Mar 4, 2026
Collaborator
acandershock
left a comment
There was a problem hiding this comment.
looks good! the huge if else statement in test-level1.mojo reminded me of gregor's class, lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To accommodate the updates, I had to change the
generate_random_arrsignature.Feel free to suggest any improvements in what and how we print, as well as more argv-controlled parameters. I'll add benchmarks for the remaining routines once I receive some feedback.