Fix aliasing violation and out-of-bounds write in lo_permutations#174
Open
SergeevGregory wants to merge 1 commit intotdep-developers:mainfrom
Open
Fix aliasing violation and out-of-bounds write in lo_permutations#174SergeevGregory wants to merge 1 commit intotdep-developers:mainfrom
SergeevGregory wants to merge 1 commit intotdep-developers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical Fortran standard violation (aliasing) in
gottochblandat_sorting.f90that causes silent heap corruption and subsequentSegmentation fault(SIGSEGV) when compiling with modern compilers (likegfortran 9.3+) under-O2or-O3optimization.The Bug
In the
lo_permutationssubroutine, the recursivegeneratefunction takes the loop counter as a dummy argumentk. However, internally it was writing to the array using the outer variablei:pm(:,i) = permutationUnder
-O2optimization, register caching causes this to repeatedly write topm(:,0)(an out-of-bounds write), which silently overwrites the heap descriptors and crashes the program later during deallocation.The Fix
Changed the array index to use the correct local dummy argument:
pm(:,k) = permutationThis ensures strict compliance with the Fortran standard and completely resolves the memory corruption issue on optimized builds.