Migrate record-reorder onto the record-mutation lifecycle driver#55
Merged
Conversation
Third record-mutation member. record-reorder rides the existing
record-mutation-lifecycle driver unchanged (useRecordWindow: true): the
runner keeps only its diff logic (seed-cache order fixture, the measured
block-reorder + routing + position verification bundle, result assembly,
restore-order-or-drop cleanup) and wires into the driver via a spec. A small
buildResult adapter maps the driver's primaryMeasurement onto the runner's
existing reorderMeasurement param so the artifact assembly is untouched.
G1 mask additions (scripts/diff-artifacts.mjs): the record-reorder baseline
A vs B diff surfaced run-to-run noise the comparator did not yet mask — this
runner is newly G1-diffed. All are genuinely volatile on unchanged code, none
semantic:
- details.verification.firstRecordId / anchorRecordId / movedRecordIds:
generated record ids (added to GENERATED_ID_KEYS, like the existing
recordId / createdRecordIds).
- details.prepare.seedBatchDurations: raw per-batch seed timings (masked like
every other *Ms / maxSeedBatchMs duration).
The semantic reorder proof stays visible and asserted: a perturbation of
verification.checkedPositions[].expectedOriginalRowNumber still fails the diff.
Verification: pnpm check green; baseline A/B and A↔candidate pass on v1+v2;
negative tests fail for phases[0].name AND checkedPositions expectedRowNumber;
masked movedRecordIds tamper correctly passes; the updated comparator still
passes for the already-migrated record-create / record-update artifacts.
Tracker: record-reorder Not migrated -> Migrated. Counts 14->15 / 35 runner
kinds, 16->17 / 55 cases.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third record-mutation member.
record-reorderrides the existingrecord-mutation-lifecycledriver unchanged (useRecordWindow: true).Scope
record-reorder(1 case) →record-reorder/10k-move-last-1k-to-frontChange
record-reorder.runner.tskeeps only its case-specific diff logic (seed-cacheorder fixture, the measured block-reorder + routing + position-verification
bundle, result assembly, restore-order-or-drop cleanup) and wires into the
driver via a spec. A small
buildResultadapter maps the driver'sprimaryMeasurementonto the runner's existingreorderMeasurementparam, sothe artifact assembly is byte-for-byte untouched.
G1 mask additions (
scripts/diff-artifacts.mjs)record-reorder is newly G1-diffed, and its baseline A vs B surfaced run-to-run
noise the comparator did not yet mask. All are genuinely volatile on unchanged
code, none semantic:
details.verification.firstRecordId/anchorRecordId/movedRecordIds:generated record ids (added to
GENERATED_ID_KEYS, like the existingrecordId/createdRecordIds).details.prepare.seedBatchDurations: raw per-batch seed timings (masked likeevery other
*Ms/maxSeedBatchMsduration).The semantic reorder proof stays visible and asserted: perturbing
verification.checkedPositions[].expectedOriginalRowNumberstill fails the diff.Verification
pnpm check: green.mask additions, confirmed sufficient by A↔B).
phases[0].nameANDcheckedPositions[].expectedOriginalRowNumberboth fail the diff; a masked
movedRecordIdstamper correctly passes.record-update artifacts (no comparator regression).
pass, phases[prepare, moveLast1kToFrontMs, seedReady], operationmove-last-block-to-front, routing matched(feature=reorderRecords), checkedPositions=4.
Protected case-contract surface (cases/**, registry.ts, framework/types.ts
config, framework/artifacts.ts schema, ../teable-ee) untouched. The
scripts/diff-artifacts.mjsmask change is explicitly task-sanctioned and masksonly run-to-run-volatile fields.
🤖 Generated with Claude Code