Skip to content

fix: add null checks for foreignRecordMap in link field update methods #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkindlund wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: add null checks for foreignRecordMap in link field update methods #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions apps/nestjs-backend/src/features/calculation/link.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,9 @@ export class LinkService {
// Update link cell values for symmetric field of the foreign table
if (toDelete.length) {
toDelete.forEach((foreignRecordId) => {
if (!foreignRecordMap[foreignRecordId]) {
return;
}
const foreignCellValue = foreignRecordMap[foreignRecordId][symmetricFieldId] as
| ILinkCellValue[]
| ILinkCellValue
Expand Down Expand Up @@ -344,6 +347,9 @@ export class LinkService {
// Update link cell values for symmetric field of the foreign table
if (oldKey?.length) {
oldKey.forEach((foreignRecordId) => {
if (!foreignRecordMap[foreignRecordId]) {
return;
}
const foreignCellValue = foreignRecordMap[foreignRecordId][symmetricFieldId] as
| ILinkCellValue[]
| ILinkCellValue
Expand Down Expand Up @@ -423,6 +429,9 @@ export class LinkService {

if (toDelete.length) {
toDelete.forEach((foreignRecordId) => {
if (!foreignRecordMap[foreignRecordId]) {
return;
}
foreignRecordMap[foreignRecordId][symmetricFieldId] = null;
});
}
Expand All @@ -433,6 +442,9 @@ export class LinkService {
const sourceRecordTitle = this.extractLinkTitle(lookupValue, sourceLookupField);

toAdd.forEach((foreignRecordId) => {
if (!foreignRecordMap[foreignRecordId]) {
return;
}
foreignRecordMap[foreignRecordId][symmetricFieldId] = {
id: recordId,
title: sourceRecordTitle,
Expand Down Expand Up @@ -465,6 +477,9 @@ export class LinkService {

if (oldKey?.length) {
oldKey.forEach((foreignRecordId) => {
if (!foreignRecordMap[foreignRecordId]) {
return;
}
foreignRecordMap[foreignRecordId][symmetricFieldId] = null;
});
}
Expand All @@ -474,10 +489,12 @@ export class LinkService {
sourceLookedFieldId != null ? sourceRecordMap[recordId]?.[sourceLookedFieldId] : undefined;
const sourceRecordTitle = this.extractLinkTitle(lookupValue, sourceLookupField);

foreignRecordMap[newKey][symmetricFieldId] = {
id: recordId,
title: sourceRecordTitle,
};
if (foreignRecordMap[newKey]) {
foreignRecordMap[newKey][symmetricFieldId] = {
id: recordId,
title: sourceRecordTitle,
};
}
}
}

Expand Down
Loading
Loading