Add detection of conflicting global type redefinitions#1127
Open
tyulpan wants to merge 1 commit into
Open
Conversation
hishamhm
reviewed
Jun 8, 2026
| }, | ||
| ["typedecl"] = { | ||
| ["typedecl"] = function(ck: TypeChecker, a: TypeDeclType, b: TypeDeclType): boolean, {Error} | ||
| return ck:same_type(a.def, b.def) |
Member
There was a problem hiding this comment.
The one thing I need to check about this PR is: are we sure that adding this does not accidentally introduce structural type compatibility to an otherwise mostly-nominal type system?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, I ran into the crash described in #1126.
My first idea was to simply ignore duplicate declarations. That would be fine for identical types.
But what if we wanted to do something like this:
Simply ignoring the duplicate declaration would be a footgun here.
And that's where I ran into another problem. Related to #1032. Currently, redeclaring a
globaltype (record,interface, ortypealias) with a different definition isn't reported as an error, and the compiler keeps the first one it finds.So let's fix that.
Resolves #1126.