fix: allow goto to a label at the end of a block#1139
Merged
Conversation
Contributor
Author
|
CI failed due to the playground timing out. Seems to be a recurring issue based on the other open PR. |
Contributor
Author
|
I think just merging this would make installing Teal with |
mbartlett21
approved these changes
Jul 10, 2026
mbartlett21
left a comment
mbartlett21
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine to me. Only comment would be on the mentioned test.
Looks like a bit of a cleaner implementation than I had done.
The goto validity check from teal-language#1121 rejected jumps over local declarations to a label at the end of a block, such as the common `goto continue` idiom. Lua permits this. A label followed only by other labels at the end of a block is outside the scope of the block's locals. The relaxation does not apply to labels at the end of a repeat body, whose locals remain visible in the until condition, nor to labels followed by a return statement, matching PUC-Lua.
mtdowling
force-pushed
the
allow-label-end-of-block
branch
from
July 11, 2026 01:33
26cc01b to
783b342
Compare
Contributor
Author
|
Thanks. I think the dev rock needs to be republished? It's still pulling down a version of Teal that keeps says |
Member
|
done, thanks for the heads up!
…On Sun, 12 Jul 2026 at 00:39, Michael Dowling ***@***.***> wrote:
*mtdowling* left a comment (teal-language/tl#1139)
<#1139 (comment)>
Thanks. I think the dev rock needs to be republished? It's still pulling
down a version of Teal that keeps says module 'teal' not found
—
Reply to this email directly, view it on GitHub
<#1139?email_source=notifications&email_token=AAB365PWMPA5SU43CWYQRLT5EMB6JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJUHE4DCMZZGYY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4949813961>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB365J2HBRPPL4TEFEJJAL5EMB6JAVCNFSNUABFKJSXA33TNF2G64TZHMYTMOBYGE2TEOBZHNEXG43VMU5TIOBTGQ2DMMRRHEYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAB365K3L3JCF5TO2XJN7MD5EMB6JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJUHE4DCMZZGYY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AAB365L2WPTWZXOF5AIOMV35EMB6JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJUHE4DCMZZGYY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goto validity check from #1121 rejected jumps over local declarations to a label at the end of a block, such as the common
goto continueidiom. Lua permits this. A label followed only by other labels at the end of a block is outside the scope of the block's locals.The relaxation does not apply to labels at the end of a repeat body, whose locals remain visible in the until condition, nor to labels followed by a return statement, matching PUC-Lua.