TEL-6183: disable video codecs#331
Conversation
Elhodred
requested review from
baloeng,
damirn,
dev-ryanc,
izzytelnyx,
minhtuan1407-telnyx and
tajamulTelnyx
minhtuan1407-telnyx
force-pushed
the
telnyx/telephony/master
branch
2 times, most recently
from
b06397d to
2afcac7
Compare
minhtuan1407-telnyx
left a comment
minhtuan1407-telnyx
left a comment
There was a problem hiding this comment.
TEL-6183: Disable Video Codecs
The code changes look correct — adding disable_video_codecs as a sofia profile param that sets CF_NOVIDEO is a clean approach, and the per-channel variable override is a nice touch.
However, two blocking issues:
1. 🔴 Wrong base branch: This PR targets telnyx/telephony/master — it MUST target telnyx/telephony/deploy-development per our branching policy. Please retarget or open a new PR against the correct base.
2. 🔴 Stale PR: This PR was opened and approved in October 2024 (17 months ago). The codebase has likely diverged significantly. Please rebase onto the current telnyx/telephony/deploy-development branch to verify no conflicts and that the changes still apply cleanly.
The code itself is fine — just needs the branch fix and a fresh rebase.
— 🦀 Review by Council of Claws
3 participants
No description provided.