Events race on frequently sending requests (#444)#994
Open
Events race on frequently sending requests (#444)#994
Conversation
krida2000
added
enhancement
krida2000
changed the title
Contributor
Author
|
FCM |
4 tasks
krida2000
commented
May 13, 2024
Comment on lines
-1521
to
+1528
| Future<void> _chatEvent(ChatEvents event) async { | ||
| Future<void> chatEvent( | ||
| ChatEvents event, { | ||
| bool updateVersion = true, | ||
| }) async { |
Contributor
Author
There was a problem hiding this comment.
@SleepySquash Не стал пока двигать этот метод наверх, так как будет очень большой diff, и не будет понятно что вообще тут поменялось.
Comment on lines
+544
to
+552
|
|
||
| @override | ||
| bool operator ==(Object other) => | ||
| other is EventChatUnfavorited && | ||
| chatId == other.chatId && | ||
| kind == other.kind; | ||
|
|
||
| @override | ||
| int get hashCode => Object.hash(chatId, kind); |
Contributor
Author
There was a problem hiding this comment.
@SleepySquash Когда мы добавляли EventPool для MyUserRepository то писали operator == для всех ивентов. Тут я не уверен что так нужно поступать, так как нам нужно уметь сравнивать не так много ивентов, а писать operator == которые не будут использоваться еще для 20+ ивентов не вижу смысла.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #444
Synopsis
Если быстро менять какой-либо статус, будет происходить гонка событий, из-за чего статус может на несколько фреймов отображаться некоректно.
Solution
Проблема будет исправлена.
Checklist
k::labels applied