Skip to content

fix: form tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nachoaldamav merged 1 commit into from
Aug 3, 2025
Merged

fix: form tests #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions bit-components/design/patterns/form/form.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { render, screen, fireEvent } from '@testing-library/react';
import { render, screen, fireEvent, act } from '@testing-library/react';
import { vi } from 'vitest';
import { Form } from './form.js';

Expand Down Expand Up @@ -40,7 +40,9 @@ describe('Form', () => {
render(<Form fields={mockFields} onSubmit={onSubmit} />);

const submitButton = screen.getByTestId('submit-button');
fireEvent.click(submitButton);
act(() => {
fireEvent.click(submitButton);
});

expect(screen.getByTestId('name-error')).toHaveTextContent('This field is required');
expect(screen.getByTestId('email-error')).toHaveTextContent('This field is required');
Expand All @@ -52,29 +54,37 @@ describe('Form', () => {
render(<Form fields={mockFields} onSubmit={onSubmit} />);

const emailInput = screen.getByTestId('email-input');
fireEvent.change(emailInput, { target: { value: 'invalid-email' } });
act(() => {
fireEvent.change(emailInput, { target: { value: 'invalid-email' } });
});

const submitButton = screen.getByTestId('submit-button');
fireEvent.click(submitButton);
act(() => {
fireEvent.click(submitButton);
});

// Wait for validation to complete
const emailError = await screen.findByTestId('email-error');
expect(emailError).toHaveTextContent('Invalid email address');
expect(onSubmit).not.toHaveBeenCalled();
});

it('should submit form with valid values', () => {
it('should submit form with valid values', async () => {
const onSubmit = vi.fn();
render(<Form fields={mockFields} onSubmit={onSubmit} />);

const nameInput = screen.getByTestId('name-input');
const emailInput = screen.getByTestId('email-input');

fireEvent.change(nameInput, { target: { value: 'John Doe' } });
fireEvent.change(emailInput, { target: { value: 'john@example.com' } });
act(() => {
fireEvent.change(nameInput, { target: { value: 'John Doe' } });
fireEvent.change(emailInput, { target: { value: 'john@example.com' } });
});

const submitButton = screen.getByTestId('submit-button');
fireEvent.click(submitButton);
await act(async () => {
fireEvent.click(submitButton);
});

expect(onSubmit).toHaveBeenCalledWith({
name: 'John Doe',
Expand Down