fix: match inspector scrollbar contrast to properties panel - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The plugin inspector iframe scrollbar was still visually prominent because:
transparent, which can render as a light colour on Linux/GTK Chromium#3b3d45) had slightly higher contrast than the right panel's scrollbarChanges
discord-plugin/.../ui/inspector.html:#2b2d31(exact body background) so the track is invisible#3d3f45(+18 luminance delta vs background, matching the right panel's#2e2e2eon#1c1c1c):hoverstate for the thumbResult
The inspector scrollbar now has the same visual weight as the properties panel scrollbar — barely visible, only showing the thumb when needed.