Multiple Corridors#44
Open
jasonplojo wants to merge 5 commits into
Open
Conversation
Added: Method to append addition corridor to the current corridor Needed: Tweak the position of the appending corridor to connect better Issues: When generating tiles, get an index out of array bounds. Most likely since there is no validation check for the appending corridor being inside the board creator.
Added: Corridors now append with correct positioning resulting in maintained corridor width Issue: Rooms with puzzles that are at the edge of the board will not create the puzzle prefab in the correct location Issue: After the rooms and corridors have been placed on the board, at times the appending corridor will result in the corridor/room being placed outside the board. This results in an error when placing the tiles.
Removed: Debug Logs Modified: Arrangement of statement for consistent code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There will now be 2 corridors in between rooms, the corridor exiting the room and the corridor that is appending to that corridor. The appending corridor will have a randomized direction, similar to the corridor exiting the room.
Known Issues