Skip to content

Refactor for a more modern API#27

Merged
mattcieslak merged 26 commits intomainfrom
cxx-17-optimizations
Feb 7, 2026
Merged

Refactor for a more modern API#27
mattcieslak merged 26 commits intomainfrom
cxx-17-optimizations

Conversation

@mattcieslak
Copy link
Collaborator

this library has been using raw pointers throughout. It would be better to use smart pointers. This PR also includes some other c++ modernizations now that we're building for c++17

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 83.50109% with 377 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.03%. Comparing base (ea9ebcb) to head (9bea625).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
include/trx/trx.tpp 80.88% 151 Missing ⚠️
src/nifti_io.cpp 30.60% 127 Missing ⚠️
src/trx.cpp 79.92% 53 Missing ⚠️
tests/test_trx_anytrxfile.cpp 92.16% 34 Missing ⚠️
include/trx/trx.h 85.00% 6 Missing ⚠️
tests/test_trx_io.cpp 96.52% 5 Missing ⚠️
src/detail/dtype_helpers.cpp 98.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   85.67%   84.03%   -1.64%     
==========================================
  Files           9       13       +4     
  Lines        2917     4724    +1807     
  Branches      460      729     +269     
==========================================
+ Hits         2499     3970    +1471     
- Misses        418      754     +336     
Flag Coverage Δ
linux 84.10% <83.39%> (-1.83%) ⬇️
macos 83.92% <83.40%> (-1.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattcieslak mattcieslak changed the title Update pointer usage Refactor for a more modern API Feb 6, 2026
@mattcieslak mattcieslak merged commit d573cb1 into main Feb 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant