[ENH] Dev-ops, N+1 offset, temporary directory#5
Draft
anibalsolon wants to merge 17 commits intomasterfrom
Draft
[ENH] Dev-ops, N+1 offset, temporary directory#5anibalsolon wants to merge 17 commits intomasterfrom
anibalsolon wants to merge 17 commits intomasterfrom
Conversation
frheault
reviewed
Nov 25, 2022
Contributor
frheault
left a comment
There was a problem hiding this comment.
I think the changes look great!
The next item on the list is about .
Maybe after that item, I can try to run the test on my new computer and see if it works?
Contributor
|
On my mac, I am currently seeing: |
Contributor
Author
|
@frheault good that it is working now- yes, this command is included in the README The gtest should have been installed via conan, not sure why it didnt find |
Contributor
|
@anibalsolon Was I doing something wrong or was the file in ./examples/load_trx.cpp not build? |
Contributor
|
@anibalsolon Is there something I can run or test before of meeting this afternoon? |
Author
|
@frheault not really- we may need to discuss some design decisions about the cpp implementation today |
mattcieslak
added a commit
to mattcieslak/trx-cpp
that referenced
this pull request
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR:
datadir