-
Notifications
You must be signed in to change notification settings - Fork 163
Add missing subpackages to tmt+all requires
#4535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Two subpackages were missing in the `tmt+all` package requires:
tmt+link-jira
tmt+provision-bootc
Add the two and sort the list to keep them organized.
Summary of ChangesHello @psss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request rectifies an oversight in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds two missing subpackage requirements, tmt+link-jira and tmt+provision-bootc, to the tmt+all metapackage in the RPM spec file. Additionally, it sorts the list of requirements alphabetically, which is a good practice for maintainability. The changes align with the optional dependencies defined for the all extra in pyproject.toml, resolving the inconsistency. The implementation is sound.
|
/gemini, please write the corresponding release note. |
|
It looks like you're trying to ask me to write a release note, but I'm not able to perform that action. My capabilities are limited to providing code reviews, pull request summaries, and responding to direct mentions in comments. You can see a list of available commands by typing |
Two subpackages were missing in the
tmt+allpackage requires:Add the two and sort the list to keep them organized.
Assisted-by: Cursor
Pull Request Checklist