Skip to content

Conversation

@psss
Copy link
Contributor

@psss psss commented Jan 29, 2026

Two subpackages were missing in the tmt+all package requires:

tmt+link-jira
tmt+provision-bootc

Add the two and sort the list to keep them organized.

Assisted-by: Cursor

Pull Request Checklist

  • implement the feature
  • include a release note

Two subpackages were missing in the `tmt+all` package requires:

    tmt+link-jira
    tmt+provision-bootc

Add the two and sort the list to keep them organized.
@gemini-code-assist
Copy link

Summary of Changes

Hello @psss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request rectifies an oversight in the tmt+all RPM package definition by integrating two previously omitted subpackages, tmt+link-jira and tmt+provision-bootc, into its dependency list. This ensures that the tmt+all package correctly pulls in all necessary components upon installation, enhancing the package's completeness and overall maintainability.

Highlights

  • Missing Subpackages Added: The tmt+all package now correctly includes tmt+link-jira and tmt+provision-bootc as required dependencies, addressing previous omissions.
  • Dependency List Sorted: The Requires list within the tmt.spec file has been reordered alphabetically to improve organization and readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@psss psss added the packaging Changes related to the rpm packaging label Jan 29, 2026
@psss psss added this to planning Jan 29, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Jan 29, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds two missing subpackage requirements, tmt+link-jira and tmt+provision-bootc, to the tmt+all metapackage in the RPM spec file. Additionally, it sorts the list of requirements alphabetically, which is a good practice for maintainability. The changes align with the optional dependencies defined for the all extra in pyproject.toml, resolving the inconsistency. The implementation is sound.

@psss
Copy link
Contributor Author

psss commented Jan 29, 2026

/gemini, please write the corresponding release note.

@gemini-code-assist
Copy link

It looks like you're trying to ask me to write a release note, but I'm not able to perform that action. My capabilities are limited to providing code reviews, pull request summaries, and responding to direct mentions in comments. You can see a list of available commands by typing /gemini help.

@psss psss added the ci | full test Pull request is ready for the full test execution label Jan 30, 2026
@psss psss moved this from backlog to review in planning Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution packaging Changes related to the rpm packaging

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

1 participant