fix(formats): use inspect module to gather annotations#1173
fix(formats): use inspect module to gather annotations#1173tefra merged 3 commits intotefra:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 116 116
Lines 9371 9374 +3
Branches 1429 1430 +1
=======================================
+ Hits 9366 9369 +3
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cecffed to
ef57bc3
Compare
ef57bc3 to
97addd5
Compare
tefra
left a comment
There was a problem hiding this comment.
Please add 3.14 to the ci
https://github.com/tefra/xsdata/blob/main/.github/workflows/tests.yml#L21
|
Hey @tefra, I'm afraid running the CI pipeline for 3.14 is not yet possible due to #1154. I ran the tests locally for python 3.14 after including the docformatter fix. Except one test all are running fine. The one that is failing is As far as I understand, this is unrelated to the change introduced in the PR.fin swimmer |
|
Python 3.9 reaches its end-of-life at the end of this month. The question is, whether you plan to drop supporting it immediately. If so we can simplify the change in this PR. |
|
Hey @tefra, I finally found a fix for the failing test under Python 3.14. I included it in this PR and activated the Python 3.14 pipeline. But for this I had to include the branch that contains the fix for How do you like to proceed? fin swimmer |
In Python 3.14 `content` might contain additional line-endings
This requires to include a feature branch version for docformatter.
a097570 to
fb92887
Compare
|
tefra
left a comment
There was a problem hiding this comment.
Thanks @finswimmer
I will merge it and either wait for an official release or try out
https://github.com/DanielNoord/pydocstringformatter
|
Happy new year 🚀 |
To be honest I was hoping for a new release of the docformatter, I don't want to have a dependency from a github repo, but we can't wait forever either... |



📒 Description
To gather type information we use now python built-in modul
inspect, which is more robust than relying on values in__dict__This change is required, because
xsdatacrashes on Python 3.14 with:This is probably due to changes in the type system (see: https://peps.python.org/pep-0649/ and https://peps.python.org/pep-0749/)
Closes: #1174