fix: Apple GLFW forward compatibility error #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create and show a window. Error below GLFW ERROR: 65543 NSGL: The targeted version of macOS only supports forward-compatible core profile contexts for OpenGL 3.2 and above GLFW error: 65543 NSGL: The targeted version of macOS only supports forward-compatible core profile contexts for OpenGL 3.2 and above r_window_create: Error: Unable to create GLFW window. r_ctx_create: unable to create window. [1] 75776 segmentation fault ../build/examples/collision
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a GLFW error on macOS that prevented OpenGL windows from being created. The error occurred because macOS requires both forward-compatible and core profile contexts for OpenGL 3.2 and above, but the code was only setting forward compatibility while using a compatibility profile.
Key changes:
- Added platform-specific conditional compilation to use
GLFW_OPENGL_CORE_PROFILEon macOS instead ofGLFW_OPENGL_COMPAT_PROFILE - This complements the existing forward-compatibility setting already in place for macOS
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying the examples out, eg collision or any of those that created a glfw window, I'd get the below error
Extra information
https://www.glfw.org/faq.html#41---how-do-i-create-an-opengl-30-context
glfw/glfw#107