-
Notifications
You must be signed in to change notification settings - Fork 234
Onboard Tekton Scheduler to operator #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9fe4a90 to
7fc9bda
Compare
7de5137 to
bd9f28a
Compare
4c1a7c9 to
78bb4d4
Compare
981a8b6 to
d12ef8f
Compare
aa0f7a6 to
2343f78
Compare
2343f78 to
cb5e579
Compare
cb5e579 to
562a12a
Compare
cfa0d55 to
149d551
Compare
|
/retest |
da805fc to
bdf5304
Compare
e2f6c2b to
40ad874
Compare
a4bbf4c to
7dee5fd
Compare
d092a75 to
6dcfacb
Compare
5264d28 to
6205922
Compare
9d9fb01 to
8cf0a10
Compare
Signed-off-by: Pramod Bindal <prbindal@redhat.com>
8cf0a10 to
cea6dac
Compare
|
@pramodbindal Please add the description for the change
Thank you |
|
@pramodbindal can we also add a document on what pre-requisite required for the scheduler to be enabled |
| package scheduler | ||
|
|
||
| // | ||
| //import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why testss are commented out here ?
We need to add these tests
|
@pramodbindal Can we add e2e tests under /test dir |
cea6dac to
a730a91
Compare
a730a91 to
8ae63c0
Compare
| | Pruner CronJob | image used in pruner cronJob | `IMAGE_JOB_PRUNER_TKN` | | ||
| | Tekton Pruner | image used by pruner controller | `IMAGE_PRUNER_CONTROLLER` | | ||
| | Tekton Pruner | image used by pruner webhook | `IMAGE_PRUNER_WEBHOOK` | | ||
| | Tekton Scheduler | image used by scheduler controller | `IMAGE_SCHEDULER_CONTROLLERO` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/IMAGE_SCHEDULER_CONTROLLERO/IMAGE_SCHEDULER_CONTROLLER
there is a nit
| errs = errs.Also(ts.Spec.MultiClusterConfig.validate()) | ||
| return errs | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you ad validation tests please
|
|
||
| } else { | ||
| // If exists, then fetch the Tekton Scheduler Config InstallerSet | ||
| installedConfigTIS, _ := r.operatorClientSet.OperatorV1alpha1().TektonInstallerSets(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please handle the error here, if err, we need to return otherwise it will panic
Changes
Onboarding Tekton Scheduler to operator.
Tekton Scheduler enables the pipeline scheduling on Single or multi cluster environment. But default this feature remains disabled.
This feature is dependent on upstream Kueue so that must be installed first before scheduler can be enabled. It also uses cert-manager so that also must be installed before head.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes