demote high-frequency Info logs to Debug on tektonaddon TaskImages #3189
Conversation
tekton-robot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
aThorp96
left a comment
aThorp96
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! Looks good to me aside from the unrelated PaC changes 👍🏼
There was a problem hiding this comment.
I think these changes may have been checked in by mistake
| return err | ||
| } | ||
| return nil | ||
| replaceParamsImage(params, images, logger) |
There was a problem hiding this comment.
Thanks for cleaning this up 🙏🏼
| ctx := context.Background() | ||
| newManifest, err := manifest.Transform(TaskImages(ctx, images)) |
There was a problem hiding this comment.
Nitpick, since we don't use the context
| ctx := context.Background() | |
| newManifest, err := manifest.Transform(TaskImages(ctx, images)) | |
| newManifest, err := manifest.Transform(TaskImages(context.Background(), images)) |
| ctx := context.Background() | ||
| newManifest, err := manifest.Transform(TaskImages(ctx, images)) |
There was a problem hiding this comment.
Nitpick, since we don't use the context otherwise
| ctx := context.Background() | |
| newManifest, err := manifest.Transform(TaskImages(ctx, images)) | |
| newManifest, err := manifest.Transform(TaskImages(context.Background(), images)) |
3 participants
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes