feat(tls): inject centrally managed TLS config into triggers webhook#3384
Open
jkhelil wants to merge 2 commits into
Open
feat(tls): inject centrally managed TLS config into triggers webhook#3384jkhelil wants to merge 2 commits into
jkhelil wants to merge 2 commits into
Conversation
…ebhook Wire the OpenShift APIServer TLS profile (TLS_MIN_VERSION, TLS_CIPHER_SUITES, TLS_CURVE_PREFERENCES) into the tekton-triggers-webhook Deployment to support PQC readiness (SRVKP-9615). Made-with: Cursor
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/kind feature |
Member
Author
|
/retest |
Member
Author
|
/retest |
Extend the OpenShift TLS profile injection to also cover the tekton-triggers-core-interceptors Deployment, in addition to the existing tekton-triggers-webhook target. Both deployments now receive TLS_MIN_VERSION, TLS_CIPHER_SUITES, and TLS_CURVE_PREFERENCES from the centrally resolved APIServer TLS profile, ensuring cluster-wide PQC-readiness policy is enforced consistently across all Triggers components (SRVKP-9615). Container name confirmed from the live cluster: tekton-triggers-core-interceptors (openshift-pipelines namespace) Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.6 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: SRVKP-9615
Problem
The tekton-triggers-webhook managed its own TLS configuration locally, preventing OpenShift's Post-Quantum Cryptography (PQC) readiness. Changes to the cluster's APIServer TLS profile had no effect on the webhook.
Solution
Wire the OpenShift APIServer TLS security profile into the triggers webhook deployment via environment variables (TLS_MIN_VERSION, TLS_CIPHER_SUITES, TLS_CURVE_PREFERENCES), and ensure any future profile changes automatically re-reconcile the webhook.
Changes:
openshift/tektontrigger/extension.go — resolve TLS profile in PreReconcile, inject it via Transformers into the tekton-triggers-webhook Deployment
shared/tektonconfig/tektonconfig.go — stamp operator.tekton.dev/platform-data-hash on the TektonTrigger CR
shared/tektonconfig/trigger/trigger.go — propagate the annotation during CR updates
Feature is opt-in via TektonConfig.spec.platforms.openShift.enableCentralTLSConfig
Evidence
Enabling the feature injects the cluster's TLS profile into the webhook:
Restrict to 3 ciphers
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes