fix: harden patch-release workflow against script injection#3424
Open
vdemeester wants to merge 1 commit into
Open
fix: harden patch-release workflow against script injection#3424vdemeester wants to merge 1 commit into
vdemeester wants to merge 1 commit into
Conversation
- Add permissions: {} for least-privilege
- Add persist-credentials: false on checkout
- Use environment variables instead of direct ${{ }} interpolation
in run: blocks to prevent script injection attacks
Aligns with the same hardening applied in tektoncd/pipeline#9671.
tekton-robot
added
kind/cleanup
tekton-robot
added
the
size/M
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Harden the
patch-release.yamlGitHub Actions workflow against script injection attacks, aligning with the same fixes applied in tektoncd/pipeline#9671.Fixes
permissions: {}— restrict workflow to least-privilege (no default token permissions)persist-credentials: false— prevent checkout action from persisting git credentials${{ inputs.* }}and${{ matrix.release.* }}interpolation inrun:blocks with environment variables (${INPUT_BRANCH},${RELEASE_VERSION}, etc.) to prevent script injectionWhy
Using
${{ }}expressions directly inrun:blocks is a known script injection vector. While the current inputs are validated or come from trusted sources, using env vars is a defense-in-depth best practice./kind cleanup
Submitter Checklist
make test lintbefore submitting a PRRelease Notes