fix(opscomments): skip key=value args as PR names

[theakshaypant]

📝 Description of the Change

When a user posts "/test custom1=value", the key=value argument was being treated as a PipelineRun name, which bypassed on-comment annotation matching. Return empty string when the first argument contains "=" so the comment falls through to on-comment handling.

🔗 Linked GitHub Issue

Fixes #1952

🧪 Testing Strategy

• Unit tests
• Integration tests
• End-to-end tests
• Manual testing
• Not Applicable

e2e test on Forgejo with /test custom1=value run successfully.

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

• I have not used any AI assistance for this PR.
• I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

• 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
• ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
• ♽ I have run make test and make lint locally to check for and fix any
  issues. For an efficient workflow, I have considered installing
  pre-commit and running pre-commit install to
  automate these checks.
• 📖 I have added or updated documentation for any user-facing changes.
• 🧪 I have added sufficient unit tests for my code changes.
• 🎁 I have added end-to-end tests where feasible. See README for more details.
• 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
• If adding a provider feature, I have filled in the following and updated the provider documentation:
  • GitHub App
  • GitHub Webhook
  • Gitea/Forgejo
  • GitLab
  • Bitbucket Cloud
  • Bitbucket Data Center

[gemini-code-assist]

Code Review

This pull request ensures that key-value arguments in comments (e.g., /test key=value) are not incorrectly parsed as PipelineRun names, allowing them to be correctly handled by on-comment annotations. The changes include logic updates in pkg/opscomments and pkg/provider, supported by new unit and E2E tests. A critical feedback point identifies a regression in pkg/provider/provider.go where comments containing both a specific PipelineRun name and parameters would fail to extract the name correctly; a suggestion was provided to split the input string by spaces before validating the name.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.29%. Comparing base (c615efb) to head (6c11540).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2712      +/-   ##
==========================================
+ Coverage   59.25%   59.29%   +0.03%     
==========================================
  Files         208      208              
  Lines       20573    20590      +17     
==========================================
+ Hits        12191    12208      +17     
  Misses       7610     7610              
  Partials      772      772              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[theakshaypant]

Will look at the deduplication of the opscomment logic in pkg/provider/provider.go and pkg/opscomment/comments.go and raise a separate PR for that if needed.

[chmouel]

/retest

[zakisk]

/retest

[zakisk]

When a user posts "/test custom1=value", the key=value argument was being treated as a PipelineRun name, which bypassed on-comment annotation matching. Return empty string when the first argument contains "=" so the comment falls through to on-comment handling.

but /test is GitOps comment not used in on-comment?

[theakshaypant]

When a user posts "/test custom1=value", the key=value argument was being treated as a PipelineRun name, which bypassed on-comment annotation matching. Return empty string when the first argument contains "=" so the comment falls through to on-comment handling.

but /test is GitOps comment not used in on-comment?

This fix is only for the case when /test is also used for on-comment.

[zakisk]

This fix is only for the case when /test is also used for on-comment.

I think then that's a collision

[zakisk]

this looks good! but we should clarify in docs that do not use PaC's standard GitOps comments in on-comment annotation.

[theakshaypant]

this looks good! but we should clarify in docs that do not use PaC's standard GitOps comments in on-comment annotation.

Added a callout in 6c11540