-
Notifications
You must be signed in to change notification settings - Fork 125
fix(profiling): enable controller profiling and update docs #2720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ require ( | |
| github.com/google/cel-go v0.28.0 | ||
| github.com/google/go-cmp v0.7.0 | ||
| github.com/google/go-github/scrape v0.0.0-20260403152401-96a365122246 | ||
| github.com/google/go-github/v84 v84.0.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| github.com/google/go-github/v85 v85.0.0 | ||
| github.com/hako/durafmt v0.0.0-20210608085754-5c1018a4e16b | ||
| github.com/jenkins-x/go-scm v1.15.17 | ||
|
|
@@ -37,15 +38,15 @@ require ( | |
| golang.org/x/exp v0.0.0-20260312153236-7ab1446f8b90 | ||
| golang.org/x/oauth2 v0.36.0 | ||
| golang.org/x/sync v0.20.0 | ||
| golang.org/x/text v0.35.0 | ||
| golang.org/x/text v0.36.0 | ||
| gopkg.in/yaml.v2 v2.4.0 | ||
| gotest.tools/v3 v3.5.2 | ||
| k8s.io/api v0.35.3 | ||
| k8s.io/apimachinery v0.35.3 | ||
| k8s.io/client-go v0.35.3 | ||
| k8s.io/api v0.35.4 | ||
| k8s.io/apimachinery v0.35.4 | ||
| k8s.io/client-go v0.35.4 | ||
| k8s.io/utils v0.0.0-20260319190234-28399d86e0b5 | ||
| knative.dev/eventing v0.48.2 | ||
| knative.dev/pkg v0.0.0-20260406140200-cb58ae50e894 | ||
| knative.dev/eventing v0.49.0 | ||
| knative.dev/pkg v0.0.0-20260422015212-ec452872dcc1 | ||
| sigs.k8s.io/yaml v1.6.0 | ||
| ) | ||
|
|
||
|
|
@@ -78,7 +79,6 @@ require ( | |
| github.com/go-openapi/swag/typeutils v0.25.5 // indirect | ||
| github.com/go-openapi/swag/yamlutils v0.25.5 // indirect | ||
| github.com/go-viper/mapstructure/v2 v2.5.0 // indirect | ||
| github.com/google/go-github/v84 v84.0.0 // indirect | ||
| github.com/oklog/ulid/v2 v2.1.1 // indirect | ||
| github.com/prometheus/otlptranslator v1.0.0 // indirect | ||
| github.com/rickb777/plural v1.4.10 // indirect | ||
|
|
@@ -149,10 +149,10 @@ require ( | |
| github.com/xlzd/gotp v0.1.0 // indirect | ||
| go.uber.org/automaxprocs v1.6.0 // indirect | ||
| go.uber.org/multierr v1.11.0 // indirect | ||
| golang.org/x/crypto v0.49.0 // indirect | ||
| golang.org/x/net v0.52.0 // indirect | ||
| golang.org/x/sys v0.42.0 // indirect | ||
| golang.org/x/term v0.41.0 | ||
| golang.org/x/crypto v0.50.0 // indirect | ||
| golang.org/x/net v0.53.0 // indirect | ||
| golang.org/x/sys v0.43.0 // indirect | ||
| golang.org/x/term v0.42.0 | ||
| golang.org/x/time v0.15.0 // indirect | ||
| gomodules.xyz/jsonpatch/v2 v2.5.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20260406210006-6f92a3bedf2d | ||
|
|
@@ -161,7 +161,7 @@ require ( | |
| google.golang.org/protobuf v1.36.11 | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| k8s.io/apiextensions-apiserver v0.35.3 // indirect | ||
| k8s.io/apiextensions-apiserver v0.35.4 // indirect | ||
| k8s.io/klog/v2 v2.140.0 | ||
| sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect | ||
| ) | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line resets the
PROFILING_PORTshell variable to8008, which will overwrite any custom port the user might have set in the previous step (e.g.,8090on line 84). This will cause a mismatch between the port the application is configured to listen on (via the Deployment environment variable) and thecontainerPortexposed in the Deployment spec, making the profiling endpoints unreachable. It is better to use a default value only if the variable is not already set.