Open
Conversation
teledu
requested changes
May 16, 2018
Owner
teledu
left a comment
There was a problem hiding this comment.
- Please remove the Lithuanian comments
- A repository (MongoModelRepository) should not reference controllers, please see other places where a model received by a controller needs to be transfered to a repository; i suggest only using separate parameters instead of a class
- Maybe it makes sense to unload some of the cloning functionality from the controller to the repository
- sourceModel.Clone() creates a cloned object with a LastRevision property value of 1, this does not correspond to the revision numbers of the cloned scenarios. Either this should be set to the highest revision for the scenarios being cloned or to the number of scenarios cloned (and each of them getting sequential numbers starting at 1)
- Use64BitIISExpress should not be in the commit
- What are the benefits of the version info span implemented like this as opposed to just having it with a fixed value inside already? I assume the content of the jsVersion field would still need to be changed manually
- There is a legacy input commented out in the clone-model-scenario-dialog.html file, it should not be there anymore
- Why are the checkboxes in clone-model-scenario-dialog.html bound to parent.selectedScenarios[scenario.id] which is a string as stated in modelCloningControllers.ts?
- Why does the modelCloningControllers.ts reference jquery?
- The way of retrieving the ids of the scenarios selected for cloning needs to be improved in general.
- Why does it redirect to the model list after cloning a model?
- $scope.cancel is indented incorrectly in modelCloningController.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.