Skip to content

Model cloning update#3

Open
zaLTys wants to merge 4 commits intoteledu:masterfrom
zaLTys:master
Open

Model cloning update#3
zaLTys wants to merge 4 commits intoteledu:masterfrom
zaLTys:master

Conversation

@zaLTys
Copy link
Copy Markdown

@zaLTys zaLTys commented Apr 16, 2018

No description provided.

Copy link
Copy Markdown
Owner

@teledu teledu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove the Lithuanian comments
  2. A repository (MongoModelRepository) should not reference controllers, please see other places where a model received by a controller needs to be transfered to a repository; i suggest only using separate parameters instead of a class
  3. Maybe it makes sense to unload some of the cloning functionality from the controller to the repository
  4. sourceModel.Clone() creates a cloned object with a LastRevision property value of 1, this does not correspond to the revision numbers of the cloned scenarios. Either this should be set to the highest revision for the scenarios being cloned or to the number of scenarios cloned (and each of them getting sequential numbers starting at 1)
  5. Use64BitIISExpress should not be in the commit
  6. What are the benefits of the version info span implemented like this as opposed to just having it with a fixed value inside already? I assume the content of the jsVersion field would still need to be changed manually
  7. There is a legacy input commented out in the clone-model-scenario-dialog.html file, it should not be there anymore
  8. Why are the checkboxes in clone-model-scenario-dialog.html bound to parent.selectedScenarios[scenario.id] which is a string as stated in modelCloningControllers.ts?
  9. Why does the modelCloningControllers.ts reference jquery?
  10. The way of retrieving the ids of the scenarios selected for cloning needs to be improved in general.
  11. Why does it redirect to the model list after cloning a model?
  12. $scope.cancel is indented incorrectly in modelCloningController.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants