feat(install): add PriorityClasses to schedule secret-manager before other operators#276
Open
feat(install): add PriorityClasses to schedule secret-manager before other operators#276
Conversation
…other operators Introduce two Kubernetes PriorityClasses (controlplane-critical and controlplane-default) and assign them via Kustomize patches so that the secret-manager pod is scheduled with higher priority than all other control plane operators. This ensures the secret-manager is started first when resources are constrained.
ron96g
requested review from
BjoernKarma,
Copilot,
iagarba,
julius-malcovsky and
stefan-ctrl
ron96g
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Kubernetes PriorityClasses and Kustomize patches to ensure secret-manager pods are scheduled ahead of other control plane components when the cluster is resource-constrained.
Changes:
- Introduce two cluster-scoped PriorityClasses:
controlplane-criticalandcontrolplane-default. - Include the new PriorityClasses in both the main and local install Kustomizations.
- Patch Deployments to set
priorityClassName(secret-managerto critical; other operators to default).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| install/priority-classes/priority-classes.yaml | Defines controlplane-critical / controlplane-default PriorityClasses. |
| install/priority-classes/kustomization.yaml | Exposes the PriorityClass manifests as a Kustomize resource. |
| install/local/kustomization.yaml | Includes PriorityClasses and patches local Deployments to set priorityClassName. |
| install/kustomization.yaml | Includes PriorityClasses and patches Deployments (remote/default install) to set priorityClassName. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rityClass Set preemptionPolicy to Never on controlplane-default so that non-critical operators get scheduling preference without evicting regular workload pods under resource pressure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce two Kubernetes PriorityClasses (controlplane-critical and
controlplane-default) and assign them via Kustomize patches so that the
secret-manager pod is scheduled with higher priority than all other
control plane operators. This ensures the secret-manager is started
first when resources are constrained.