feat: textarea/Datepicker updates - fix pipeline#2480
Merged
amir-ba merged 13 commits intotelekom:mainfrom Apr 10, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Amir Baghdoust <baghdoust@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the hide-label-visually feature for both scale-textarea and scale-date-picker components, allowing labels to be visually hidden while remaining accessible to screen readers. This is part of PR #2471's broader "Hidden Label Visually" implementation update.
Changes:
- Added
hideLabelVisuallyprop to both textarea and date-picker components - Implemented CSS styling to hide labels visually using
visibility: hiddenwith appropriate padding adjustments - Added comprehensive test coverage including spec, e2e, and snapshot tests for textarea
- Updated HTML test files with examples demonstrating the feature
- Fixed an accessibility bug in textarea by correcting
aria-describedBytoaria-describedby - Updated component documentation to include the new property
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| textarea.tsx | Added hideLabelVisually prop and CSS class application, fixed aria-describedby attribute |
| textarea.spec.ts | Added snapshot and unit tests for the new property |
| textarea.e2e.ts | Added e2e tests to verify CSS class behavior |
| textarea.css | Added styles to hide label and adjust padding |
| textarea readme.md | Documented the new property in alphabetical order |
| textarea.html | New HTML test page demonstrating the hidden label feature |
| date-picker.tsx | Added hideLabelVisually prop and CSS class application |
| date-picker.css | Added styles to hide label and adjust padding |
| date-picker readme.md | Documented the new property in alphabetical order |
| date-picker.html | Added example section demonstrating the hidden label feature |
| date-picker visual snapshot | Updated visual test snapshot for the standard variant |
| textarea snapshot | Updated with new hide-label-visually test snapshot |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amir-ba
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added 2 snapshot updates to:
#2471