fix(css): correct font format fallback#2481
Open
grigoriy-reshetniak wants to merge 2 commits intotelekom:mainfrom
Open
fix(css): correct font format fallback#2481grigoriy-reshetniak wants to merge 2 commits intotelekom:mainfrom
grigoriy-reshetniak wants to merge 2 commits intotelekom:mainfrom
Conversation
Collaborator
|
@grigoriy-reshetniak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to bug in font order newest font format
woff2was used as fallback forwoff. This PR changes the fallback order makingwofffallback forwoff2.woff2has a better compression and should be preferred generally. It's also widely adopted.Taking advantage of the opportunity I'd like to ask why
eot(or evenwoffto certain extent) is needed? IE 11 is retired by MS, marked as dead in by Browserlist. It has less than 1% of usage. Is it really worth to have this font format in the repository?