Fix RGBA color handling in truecolor mode#1
Open
Felixdiamond wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RGBA color handling in truecolor mode
Problem
When using truecolor mode (
--mode truecolor), the application crashes with aValueError: too many values to unpack (expected 3)error when processing GIFs that contain RGBA color data. This occurs because some GIFs contain alpha channel information (RGBA format) but the color processors expect RGB format. Plus it loops foreverSolution
Modified the color processors to safely handle both RGB and RGBA color inputs by taking only the first three color components (RGB). This maintains compatibility with existing GIFs while adding support for RGBA GIFs.
Changes made:
color[:3]slicing in all processorpre()methods to consistently handle RGB valuesTesting
Tested with:
Before (with RGBA GIF):
After (with RGBA GIF):
Impact
This change: