feat(discovery): add support for dynamic path exlusion#2045
Open
feat(discovery): add support for dynamic path exlusion#2045
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit fc05662 |
Member
|
@innocenzi - why don't we just add exclusion rules and include a couple smart defaults? |
Member
Author
|
The discovery config already has something similar, but nothing dynamic, I assume for performance. I think adding static closure support would be fine too, but in this specific case, we already have a workaround for Pest within Tempest, and I'm extending it for outside of Tempest, I don't think all Pest users should manually have to debug that weird error |
Member
Author
|
@aidan-casey I added the functionality anyway because it's useful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for dynamically excluding paths from being discovered:
It also includes another fix for when Tempest scans a Pest test file:
When encountering a test or
Pest.phpfile,class_existsornew ClassReflectorthrows because it autoloads the file.