Init#2
Conversation
There was a problem hiding this comment.
Pull request overview
This PR initializes a new CLI tool for Temporal Cloud management, implementing namespace operations and authentication capabilities.
Key Changes:
- Sets up the core CLI framework with command generation from YAML definitions
- Implements namespace management commands (get, apply, edit)
- Adds OAuth-based login functionality for cloud authentication
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Declares Go 1.25.3 and project dependencies |
| temporalcloudcli/commands.yml | Defines CLI command structure and options |
| temporalcloudcli/namespace.go | Implements namespace client operations |
| temporalcloudcli/commands.namespace.go | Implements namespace command handlers |
| temporalcloudcli/commands.login.go | Implements OAuth login flow |
| temporalcloudcli/common.go | Provides utility functions for async operations and JSON handling |
| temporalcloudcli/commandsgen/*.go | Code generation utilities for CLI commands |
| temporalcloudcli/internal/printer/*.go | Output formatting utilities for text and JSON |
| temporalcloudcli/commands*.go | Generated and core command infrastructure |
| temporalcloudcli/cloud.go | Cloud client initialization |
| cmd/temporal-cloud/main.go | CLI entrypoint |
| README.md | Project description |
| Makefile | Build automation |
| CODEOWNERS | Code ownership definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![semgrep-managed-scans[bot]](https://avatars.githubusercontent.com/u/56493103?s=60&v=4){kind=small}
| runs-on: ubuntu-latest | ||
| needs: verify-generation | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v5 | ||
| - name: Build the cli binary | ||
| run: make build |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by missing-explicit-permissions.
You can view more details about this finding in the Semgrep AppSec Platform.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v5 | ||
| - name: Run commands generation command | ||
| run: make gen | ||
| - name: Verify no changes were generated | ||
| run: | | ||
| # Check if the working directory is dirty | ||
| if git diff-index --quiet HEAD --; then | ||
| echo "::notice::Generated files are up to date. No changes detected." | ||
| else | ||
| echo "::error::Detected uncommitted changes after running the generation command. Please run the generator and commit the changes." | ||
| git status | ||
| git diff | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by missing-explicit-permissions.
You can view more details about this finding in the Semgrep AppSec Platform.
No description provided.