deprecate legacy config#223
Closed
liam-lowe wants to merge 1 commit into
Closed
Conversation
liam-lowe
added a commit
that referenced
this pull request
May 4, 2026
The StringMapping yaml tags are local/remote (config/cluster_conn_config.go:29-30), not localString/remoteString. The active mapping in local-test-config-client.yaml has been wrong since b5436d0 — silently parsed before, but now fails the strict YAML decoder since #223 dropped the legacy converter shim. Also corrects the commented example in local-test-config-server.yaml so it doesn't propagate the typo.
liam-lowe
added a commit
that referenced
this pull request
May 4, 2026
The StringMapping yaml tags are local/remote (config/cluster_conn_config.go:29-30), not localString/remoteString. The active mapping in local-test-config-client.yaml has been wrong since b5436d0 — silently parsed before, but now fails the strict YAML decoder since #223 dropped the legacy converter shim. Also corrects the commented example in local-test-config-server.yaml so it doesn't propagate the typo.
liam-lowe
force-pushed
the
liam/deprecate-legacy-config
branch
2 times, most recently
from
6da849e to
a55401c
Compare
liam-lowe
force-pushed
the
liam/deprecate-legacy-config
branch
from
a55401c to
f5e25e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: