Enforce LF line endings for compose setup shell script#128
Open
GeorgeSpring wants to merge 1 commit intotemporalio:mainfrom
Open
Enforce LF line endings for compose setup shell script#128GeorgeSpring wants to merge 1 commit intotemporalio:mainfrom
GeorgeSpring wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
|
GeorgeSpring
force-pushed
the
fix/compose-setup-shell-lf-line-endings
branch
from
6711707 to
9928c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Enforced LF line endings for the
compose/scripts/setup-postgres-es.shscript via.gitattributes.No changes to the script logic itself.
Why?
Although the script is stored with LF line endings in the repository, Git may check it out as CRLF on Windows due to
core.autocrlf. When the file is mounted into a Linux Docker container, this causes the POSIX/bin/shscript to fail with:Enforcing LF line endings at the Git level ensures the docker-compose setup works reliably across platforms.
Checklist
core.autocrlf=true/bin/sherrors