Skip to content

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Jan 28, 2026

What was changed

  • Make sure that the image, during create time, has the right image config so that kubelet can rightly validate against it.
  • kubelet could not prove that the string "USER nonroot" is not the root. The following changes do that.

Why?

  • Correctness.

Checklist

  1. Closes
    [Bug] Helm chart deployment fails on v1.2.0: "container has runAsNonRoot and image has non-numeric user (nonroot)" #192
    Helm chart: Add runAsUser support to pod securityContext #193

  2. How was this tested:

  1. Any docs updates needed?

@Shivs11 Shivs11 requested review from a team and jlegrone as code owners January 28, 2026 22:20
COPY --chown=nonroot:nonroot temporal-worker-controller /usr/local/bin/temporal-worker-controller

USER nonroot
COPY --chown=65532:65532 temporal-worker-controller /usr/local/bin/temporal-worker-controller
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also changed this to just have 65532 rather than nonroot to be more reliable: I think --chown=nonroot:nonroot depends on the build environment being able to resolve the names nonroot and nonroot to IDs during the COPY.

no need to maybe take this risk and just be explicit in nature.

@Shivs11 Shivs11 enabled auto-merge (squash) February 2, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants