Nexus Standalone: use parallelsuite#9885
Draft
stephanos wants to merge 11 commits intofeature/nexus-standalonefrom
Draft
Nexus Standalone: use parallelsuite#9885stephanos wants to merge 11 commits intofeature/nexus-standalonefrom
stephanos wants to merge 11 commits intofeature/nexus-standalonefrom
Conversation
stephanos
commented
Apr 9, 2026
| endpointName := createNexusEndpoint(s) | ||
| func (s *NexusStandaloneTestSuite) TestStartStandaloneNexusOperation() { | ||
| s.Run("StartAndDescribe", func(s *NexusStandaloneTestSuite) { | ||
| env := newNexusTestEnv(s.T(), false, s.opts()...) |
Contributor
Author
There was a problem hiding this comment.
Re-use existing newNexusTestEnv
05eba07 to
151f881
Compare
88281af to
c50d8ba
Compare
151f881 to
91e72b2
Compare
d294049 to
9d806ef
Compare
91e72b2 to
b605c00
Compare
22ed5f4 to
8b51e02
Compare
Add API boilerplate for standalone Nexus Operations. - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
Add Nexus Standalone feature flag. Tests will be added to respective API impl.
Add Nexus Standalone Describe and Start handlers. - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add Nexus Standalone List and Count handlers. - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8b51e02 to
d13cafb
Compare
b605c00 to
9ba395d
Compare
9ba395d to
cc1f598
Compare
stephanos
commented
Apr 13, 2026
| s.Require().Eventually(func() bool { | ||
| resp, err = env.FrontendClient().StartNexusOperationExecution(env.Context(), req) | ||
| return err == nil || !isRetryableStartNexusOperationError(err) | ||
| }, 10*time.Second, 100*time.Millisecond, "start operation should succeed once the endpoint is visible") |
Contributor
Author
There was a problem hiding this comment.
Need this to ensure Start is not flaky due to endpoint not found.
stephanos
commented
Apr 13, 2026
| s.NoError(err) | ||
| protorequire.ProtoEqual(s.T(), &workflowservice.DescribeNexusOperationExecutionResponse{}, longPollResp) | ||
|
|
||
| t.Run("NoCallerDeadline", func(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
Inlined these now since mixing Run and assertions is not allowed in parallelsuite
cc1f598 to
6fdf95c
Compare
6fdf95c to
80ec9ee
Compare
a339919 to
aec2bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Convert nexus standalone test suite to use parallelsuite.
Why?
Consistency and speed.
How did you test it?