Skip to content

Nexus Standalone: use parallelsuite#9885

Draft
stephanos wants to merge 11 commits intofeature/nexus-standalonefrom
stephanos/sano-parallelsuite
Draft

Nexus Standalone: use parallelsuite#9885
stephanos wants to merge 11 commits intofeature/nexus-standalonefrom
stephanos/sano-parallelsuite

Conversation

@stephanos
Copy link
Copy Markdown
Contributor

@stephanos stephanos commented Apr 9, 2026

What changed?

Convert nexus standalone test suite to use parallelsuite.

Why?

Consistency and speed.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@stephanos stephanos changed the base branch from main to feature/nexus-standalone April 9, 2026 02:32
@stephanos stephanos changed the title Stephanos/sano parallelsuite Nexus Standalone: use parallelsuite Apr 9, 2026
endpointName := createNexusEndpoint(s)
func (s *NexusStandaloneTestSuite) TestStartStandaloneNexusOperation() {
s.Run("StartAndDescribe", func(s *NexusStandaloneTestSuite) {
env := newNexusTestEnv(s.T(), false, s.opts()...)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-use existing newNexusTestEnv

@stephanos stephanos force-pushed the stephanos/sano-parallelsuite branch 5 times, most recently from 05eba07 to 151f881 Compare April 9, 2026 03:15
@stephanos stephanos force-pushed the feature/nexus-standalone branch from 88281af to c50d8ba Compare April 9, 2026 14:22
@stephanos stephanos force-pushed the stephanos/sano-parallelsuite branch from 151f881 to 91e72b2 Compare April 9, 2026 14:28
@stephanos stephanos force-pushed the feature/nexus-standalone branch 3 times, most recently from d294049 to 9d806ef Compare April 9, 2026 16:35
@stephanos stephanos force-pushed the stephanos/sano-parallelsuite branch from 91e72b2 to b605c00 Compare April 9, 2026 18:30
@stephanos stephanos force-pushed the feature/nexus-standalone branch 3 times, most recently from 22ed5f4 to 8b51e02 Compare April 13, 2026 19:48
stephanos and others added 8 commits April 13, 2026 13:48
Add API boilerplate for standalone Nexus Operations.

- [x] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
Add Nexus Standalone feature flag.

Tests will be added to respective API impl.
Add Nexus Standalone Describe and Start handlers.

- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [x] added new unit test(s)
- [x] added new functional test(s)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add Nexus Standalone List and Count handlers.

- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [x] added new functional test(s)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@stephanos stephanos force-pushed the feature/nexus-standalone branch from 8b51e02 to d13cafb Compare April 13, 2026 20:51
@stephanos stephanos force-pushed the stephanos/sano-parallelsuite branch from b605c00 to 9ba395d Compare April 13, 2026 21:32
@stephanos stephanos force-pushed the stephanos/sano-parallelsuite branch from 9ba395d to cc1f598 Compare April 13, 2026 22:47
Comment thread tests/nexus_standalone_test.go Outdated
s.Require().Eventually(func() bool {
resp, err = env.FrontendClient().StartNexusOperationExecution(env.Context(), req)
return err == nil || !isRetryableStartNexusOperationError(err)
}, 10*time.Second, 100*time.Millisecond, "start operation should succeed once the endpoint is visible")
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this to ensure Start is not flaky due to endpoint not found.

s.NoError(err)
protorequire.ProtoEqual(s.T(), &workflowservice.DescribeNexusOperationExecutionResponse{}, longPollResp)

t.Run("NoCallerDeadline", func(t *testing.T) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inlined these now since mixing Run and assertions is not allowed in parallelsuite

@stephanos stephanos force-pushed the stephanos/sano-parallelsuite branch from cc1f598 to 6fdf95c Compare April 13, 2026 22:53
@stephanos stephanos force-pushed the stephanos/sano-parallelsuite branch from 6fdf95c to 80ec9ee Compare April 13, 2026 23:02
@stephanos stephanos force-pushed the feature/nexus-standalone branch 3 times, most recently from a339919 to aec2bf4 Compare April 14, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant