DescribeWorkflow reads pending nexus operations from CHASM#9913
Open
S15 wants to merge 1 commit intotemporalio:mainfrom
Open
DescribeWorkflow reads pending nexus operations from CHASM#9913S15 wants to merge 1 commit intotemporalio:mainfrom
S15 wants to merge 1 commit intotemporalio:mainfrom
Conversation
bergundy
reviewed
Apr 10, 2026
| o.Status = status | ||
| } | ||
|
|
||
| func cancellationAPIState(status nexusoperationpb.CancellationStatus) enumspb.NexusOperationCancellationState { |
Member
There was a problem hiding this comment.
This should be implemented in @stephanos's standalone nexus branch. Add a TODO to remove the duplication please.
Comment on lines
+67
to
+68
| // ToCancellationInfo converts a CHASM Cancellation to the API NexusOperationCancellationInfo format. | ||
| func (o *Cancellation) ToCancellationInfo(circuitBreakerOpen func(endpoint string) bool, endpoint string) *workflowpb.NexusOperationCancellationInfo { |
Member
There was a problem hiding this comment.
Suggested change
| // ToCancellationInfo converts a CHASM Cancellation to the API NexusOperationCancellationInfo format. | |
| func (o *Cancellation) ToCancellationInfo(circuitBreakerOpen func(endpoint string) bool, endpoint string) *workflowpb.NexusOperationCancellationInfo { | |
| // ToWorkflowCancellationInfo converts a CHASM Cancellation to the API workflow.NexusOperationCancellationInfo format. | |
| func (o *Cancellation) ToWorkflowCancellationInfo(circuitBreakerOpen func(endpoint string) bool, endpoint string) *workflowpb.NexusOperationCancellationInfo { |
| return nil | ||
| } | ||
|
|
||
| func pendingOperationState(status nexusoperationpb.OperationStatus) enumspb.PendingNexusOperationState { |
Member
There was a problem hiding this comment.
Same as above, it's part of standalone nexus.
Comment on lines
+278
to
+280
| // ToPendingNexusOperationInfo converts a CHASM Operation to the API PendingNexusOperationInfo format. | ||
| // Returns nil if the operation is not in a pending state. | ||
| func (o *Operation) ToPendingNexusOperationInfo( |
Member
There was a problem hiding this comment.
Suggested change
| // ToPendingNexusOperationInfo converts a CHASM Operation to the API PendingNexusOperationInfo format. | |
| // Returns nil if the operation is not in a pending state. | |
| func (o *Operation) ToPendingNexusOperationInfo( | |
| // ToWorkflowPendingNexusOperationInfo converts a CHASM Operation to the API workflow.PendingNexusOperationInfo format. | |
| // Returns nil if the operation is not in a pending state. | |
| func (o *Operation) ToWorkflowPendingNexusOperationInfo( |
Member
There was a problem hiding this comment.
Also tempted to put this in chasm/lib/workflow instead because the component should be mostly agnostic to where it is used.
Comment on lines
+297
to
+300
| if state == enumspb.PENDING_NEXUS_OPERATION_STATE_SCHEDULED && invocationCBOpen(o.Endpoint) { | ||
| state = enumspb.PENDING_NEXUS_OPERATION_STATE_BLOCKED | ||
| blockedReason = "The circuit breaker is open." | ||
| } |
Member
There was a problem hiding this comment.
@stephanos I don't remember seeing this in your standalone branch. Did we miss this?
| } | ||
|
|
||
| // buildPendingNexusOperationInfosFromChasm reads nexus operations from the CHASM tree and converts them to API format. | ||
| func buildPendingNexusOperationInfosFromChasm( |
Member
There was a problem hiding this comment.
Move all of this to chasm/lib/workflow please.
Comment on lines
+586
to
+602
| invocationBreaker := func(endpoint string) bool { | ||
| cb := outboundQueueCBPool.Get(tasks.TaskGroupNamespaceIDAndDestination{ | ||
| TaskGroup: nexusoperations.TaskTypeInvocation, | ||
| NamespaceID: namespaceID.String(), | ||
| Destination: endpoint, | ||
| }) | ||
| return cb.State() != gobreaker.StateClosed | ||
| } | ||
|
|
||
| cancellationBreaker := func(endpoint string) bool { | ||
| cb := outboundQueueCBPool.Get(tasks.TaskGroupNamespaceIDAndDestination{ | ||
| TaskGroup: nexusoperations.TaskTypeCancelation, | ||
| NamespaceID: namespaceID.String(), | ||
| Destination: endpoint, | ||
| }) | ||
| return cb.State() != gobreaker.StateClosed | ||
| } |
Member
There was a problem hiding this comment.
I think the task group is wrong here, it using definitions from the HSM implementation.
Let's also make sure we have a way to put both of these in the same task group. There's no need to separate them out. It's been an outstanding item for a while.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test it?