Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/rpc/encryption/fixedTLSConfigProvider.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ func (f *FixedTLSConfigProvider) GetFrontendClientConfig() (*tls.Config, error)

// GetRemoteClusterClientConfig implements [TLSConfigProvider.GetRemoteClusterClientConfig].
func (f *FixedTLSConfigProvider) GetRemoteClusterClientConfig(hostname string) (*tls.Config, error) {
return f.RemoteClusterClientConfigs[hostname], nil
if cfg, ok := f.RemoteClusterClientConfigs[hostname]; ok {
return cfg, nil
}
// Fall back to default config
return f.RemoteClusterClientConfigs[defaultRemoteCluster], nil
}

// GetExpiringCerts implements [TLSConfigProvider.GetExpiringCerts].
Expand Down
12 changes: 10 additions & 2 deletions common/rpc/encryption/local_store_tls_provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ type localStoreTlsProvider struct {
var _ TLSConfigProvider = (*localStoreTlsProvider)(nil)
var _ CertExpirationChecker = (*localStoreTlsProvider)(nil)

const defaultRemoteCluster = "default"

func NewLocalStoreTlsProvider(tlsConfig *config.RootTLS, metricsHandler metrics.Handler, logger log.Logger, certProviderFactory CertProviderFactory,
) (TLSConfigProvider, error) {

Expand Down Expand Up @@ -139,16 +141,22 @@ func (s *localStoreTlsProvider) GetFrontendClientConfig() (*tls.Config, error) {
}

func (s *localStoreTlsProvider) GetRemoteClusterClientConfig(hostname string) (*tls.Config, error) {
certProviderKey := hostname
groupTLS, ok := s.settings.RemoteClusters[hostname]
if !ok {
return nil, nil
// Fall back to default/wildcard config if present
groupTLS, ok = s.settings.RemoteClusters[defaultRemoteCluster]
if !ok {
return nil, nil
}
certProviderKey = defaultRemoteCluster
}

return s.getOrCreateRemoteClusterClientConfig(
hostname,
func() (*tls.Config, error) {
return newClientTLSConfig(
s.remoteClusterClientCertProvider[hostname],
s.remoteClusterClientCertProvider[certProviderKey],
groupTLS.Client.ServerName,
groupTLS.Server.RequireClientAuth,
false,
Expand Down
103 changes: 103 additions & 0 deletions common/rpc/encryption/tls_config_test.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
package encryption

import (
"crypto/tls"
"crypto/x509"
"testing"
"time"

"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
)

type (
Expand Down Expand Up @@ -218,3 +223,101 @@ func (s *tlsConfigTest) TestSystemWorkerTLSConfig() {
client.RootCAData = []string{""}
s.Error(validateRootTLS(cfg))
}

// stubCertProvider is a no-op CertProvider for use in unit tests.
type stubCertProvider struct{}

func (s *stubCertProvider) FetchServerCertificate() (*tls.Certificate, error) { return nil, nil }
func (s *stubCertProvider) FetchClientCAs() (*x509.CertPool, error) { return nil, nil }
func (s *stubCertProvider) FetchClientCertificate(_ bool) (*tls.Certificate, error) {
return nil, nil
}
func (s *stubCertProvider) FetchServerRootCAsForClient(_ bool) (*x509.CertPool, error) {
return nil, nil
}
func (s *stubCertProvider) GetExpiringCerts(_ time.Duration) (expiring CertExpirationMap, expired CertExpirationMap, err error) {
return nil, nil, nil
}

func stubCertProviderFactory(_ *config.GroupTLS, _ *config.WorkerTLS, _ *config.ClientTLS, _ time.Duration, _ log.Logger) CertProvider {
return &stubCertProvider{}
}

func newTestTLSProvider(t *testing.T, cfg config.RootTLS) TLSConfigProvider {
t.Helper()
provider, err := NewLocalStoreTlsProvider(&cfg, metrics.NoopMetricsHandler, log.NewTestLogger(), stubCertProviderFactory)
require.NoError(t, err)
return provider
}

func TestGetRemoteClusterClientConfig_NoConfig(t *testing.T) {
provider := newTestTLSProvider(t, config.RootTLS{})
tlsCfg, err := provider.GetRemoteClusterClientConfig("some-host")
require.NoError(t, err)
require.Nil(t, tlsCfg)
}

func TestGetRemoteClusterClientConfig_UnknownHostNoDefault(t *testing.T) {
cfg := config.RootTLS{
RemoteClusters: map[string]config.GroupTLS{
"cluster-a.example.com": {Client: config.ClientTLS{ForceTLS: true}},
},
}
provider := newTestTLSProvider(t, cfg)

tlsCfg, err := provider.GetRemoteClusterClientConfig("unknown-host.example.com")
require.NoError(t, err)
require.Nil(t, tlsCfg)
}

func TestGetRemoteClusterClientConfig_ExactMatch(t *testing.T) {
cfg := config.RootTLS{
RemoteClusters: map[string]config.GroupTLS{
"cluster-a.example.com": {Client: config.ClientTLS{ForceTLS: true}},
},
}
provider := newTestTLSProvider(t, cfg)

tlsCfg, err := provider.GetRemoteClusterClientConfig("cluster-a.example.com")
require.NoError(t, err)
require.NotNil(t, tlsCfg)

// Unknown host with no default → nil
tlsCfg, err = provider.GetRemoteClusterClientConfig("cluster-b.example.com")
require.NoError(t, err)
require.Nil(t, tlsCfg)
}

func TestGetRemoteClusterClientConfig_DefaultFallback(t *testing.T) {
cfg := config.RootTLS{
RemoteClusters: map[string]config.GroupTLS{
defaultRemoteCluster: {Client: config.ClientTLS{ForceTLS: true}},
},
}
provider := newTestTLSProvider(t, cfg)

tlsCfg, err := provider.GetRemoteClusterClientConfig("any-unknown-host")
require.NoError(t, err)
require.NotNil(t, tlsCfg)
}

func TestGetRemoteClusterClientConfig_ExactMatchTakesPriority(t *testing.T) {
cfg := config.RootTLS{
RemoteClusters: map[string]config.GroupTLS{
"cluster-a.example.com": {Client: config.ClientTLS{ForceTLS: false}},
// Default has ForceTLS: false so IsClientEnabled() returns false → nil config
defaultRemoteCluster: {Client: config.ClientTLS{ForceTLS: true}},
},
}
provider := newTestTLSProvider(t, cfg)

// Exact match → nil (ForceTLS: false)
tlsCfg, err := provider.GetRemoteClusterClientConfig("cluster-a.example.com")
require.NoError(t, err)
require.Nil(t, tlsCfg)

// Unknown host falls back to default (ForceTLS: true) → non-nil
tlsCfg, err = provider.GetRemoteClusterClientConfig("unknown-host")
require.NoError(t, err)
require.NotNil(t, tlsCfg)
}
Loading