fix: prevent 'No Workers Running' flash during workflow load #3131
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add workersLoaded flag to distinguish between "loading workers" and "loaded with no workers" states. This fixes a race condition where the warning would briefly appear before worker data finished loading. The warning now only shows when workers have been definitively loaded and found to be empty, not during the initial loading phase.
rossnelson
requested review from
a team,
Alex-Tideman and
rossedfort
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| @@ -97,7 +97,7 @@ | |||
| const { taskQueue } = workflow; | |||
| const workers = await getPollers({ queue: taskQueue, namespace }); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
⚠️ Type 'WorkflowExecution | undefined' is not assignable to type 'WorkflowExecution | null'.
| $workflowRun = { ...$workflowRun, workflow, workers, workersLoaded: true }; | ||
|
|
||
| workflowRunController = new AbortController(); | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ 'workflow' is possibly 'undefined'.
| export const initialWorkflowRun: WorkflowRunWithWorkers = { | ||
| workflow: null, | ||
| workers: { pollers: [], taskQueueStatus: null }, | ||
| workersLoaded: false, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'undefined' is not assignable to type 'WorkflowMetadata'.
Contributor
|
Alex-Tideman
reviewed
Feb 4, 2026
| const workers = await getPollers({ queue: taskQueue, namespace }); | ||
|
|
||
| $workflowRun = { ...$workflowRun, workflow, workers }; | ||
| $workflowRun = { ...$workflowRun, workflow, workers, workersLoaded: true }; |
Collaborator
There was a problem hiding this comment.
Do we ever set this back to false onDestroy/navigate away from workflow page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition where the "No Workers Running" warning would briefly flash when opening a workflow, even when workers were actively running.
Root cause: The
workflow-call-stack-errorcomponent checked!workers?.pollers?.lengthto show the warning, but the initial store state haspollers: []. When a workflow loaded, the warning would briefly appear before worker data finished loading.Fix: Added a
workersLoadedflag to the store to distinguish between:workersLoaded: false,pollers: [])workersLoaded: true,pollers: [])The warning now only shows in the second case.
Changes
src/lib/stores/workflow-run.ts- AddedworkersLoaded: booleanto store typesrc/lib/layouts/workflow-run-layout.svelte- SetsworkersLoaded: trueafter fetchingsrc/lib/components/workflow/workflow-call-stack-error.svelte- ChecksworkersLoadedbefore showing warningTest plan