Skip to content

feat: add action pin policy to scanner#30

Merged
grandizzy merged 7 commits into
tempoxyz:mainfrom
mablr:mablr/check-action-pins
Jul 16, 2026
Merged

feat: add action pin policy to scanner#30
grandizzy merged 7 commits into
tempoxyz:mainfrom
mablr:mablr/check-action-pins

Conversation

@mablr

@mablr mablr commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Extends the existing scan-github-actions workflow with opt-in pinact policy checks for minimum release age and version comments.

Existing scanner callers remain unchanged because pinact defaults to disabled. Callers can enable it with pinact: true, retain repository-local .pinact.yaml exceptions, and run the policy in the scanner’s existing checkout and job.

Validation

  • actionlint v1.7.12
  • YAML parsing
  • git diff --check

Closes OSS-542

@mablr
mablr force-pushed the mablr/check-action-pins branch from c475557 to a7a63ed Compare July 14, 2026 15:11

@grandizzy grandizzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! the full-SHA enforcement duplicates zizmor / scan GH action, atm only minimum-age checking (7 days old) is different which we coul fold in existing one?

@mablr mablr changed the title feat: add action pin check workflow feat: add action pin policy to scanner Jul 15, 2026
@mablr

mablr commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@grandizzy good point, rescoped pr fd2f625, ptal :)

@mablr
mablr requested a review from grandizzy July 15, 2026 12:42

@grandizzy grandizzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the inline finding.

Comment thread .github/workflows/scan-github-actions.yml
@tempo-voight-kampff

Copy link
Copy Markdown

Hi @grandizzy — your changes-requested review was detected by Voight-Kampff, but you rejected the approval request. Your review did not count toward this PR.

The prompt was canceled.

This request was for head fd2f625d6b83.

Re-submit the review and complete the new Voight-Kampff prompt if you want this review to count.

@mablr
mablr requested a review from grandizzy July 16, 2026 08:18

@grandizzy grandizzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pinact integration and read-only permissions look correct, but the new regression test currently fails because it retains the deliberately broken fixture. One inline blocker; no other findings.

Comment thread .github/workflows/test.yml
@tempo-voight-kampff

Copy link
Copy Markdown

Hi @grandizzy — your changes-requested review was detected by Voight-Kampff, but you rejected the approval request. Your review did not count toward this PR.

The prompt was canceled.

This request was for head fbf53726895f.

Re-submit the review and complete the new Voight-Kampff prompt if you want this review to count.

@grandizzy grandizzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty!

@grandizzy
grandizzy merged commit bc4cc46 into tempoxyz:main Jul 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants