fix: prevent SecurityError from external hash fragments on landing page#1
Draft
tenderdeve wants to merge 1 commit into
Draft
fix: prevent SecurityError from external hash fragments on landing page#1tenderdeve wants to merge 1 commit into
tenderdeve wants to merge 1 commit into
Conversation
When a URL like app.uniswap.org/#//example.org is opened, stripping the '#' leaves '//example.org' which React Router passes to history.replaceState. The browser rejects protocol-relative URLs from a different origin, throwing a SecurityError and showing the error overlay. Only redirect when the resulting path starts with a single '/', which preserves all valid legacy hash routes like #/swap while ignoring external-looking fragments. Fixes Uniswap#7979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening
app.uniswap.org/#//example.orgcauses aSecurityErrorbecausehash.replace('#', '')yields//example.org— a protocol-relative URL — whichhistory.replaceStaterefuses to set from a different origin. The error overlay appears until the page is reloaded.The fix adds a guard so the redirect only fires when the stripped hash starts with a single
/, preserving all valid legacy hash routes (e.g.#/swap) while safely ignoring any external-looking fragments.Upstream issue: Uniswap#7979