fix: correct tooltip z-index in confirmation popup#2
Draft
tenderdeve wants to merge 1 commit into
Draft
Conversation
Use EffectiveModalOrSheetZIndexContext to ensure tooltip content renders above the modal layer, matching the pattern used by AdaptiveWebPopoverContent. Fixes Uniswap#7988
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooltips rendered inside confirmation modals can appear behind other popup content because the tooltip portal doesn't account for the modal's z-index layer. This uses EffectiveModalOrSheetZIndexContext (the same approach AdaptiveWebPopoverContent already follows) to resolve the tooltip z-index relative to the hosting modal.
Upstream issue: Uniswap#7988
Tested by verifying tooltip z-index resolution uses the effective modal stacking context when present, falling back to zIndexes.tooltip otherwise.