feat(writes): all-or-nothing batch corrections (refs #1)#31
Merged
Conversation
apply_corrections now runs in two phases: compute every change in memory first, then write them; if any write fails, restore the files already written from their in-memory originals and re-raise. A bulk `correct --apply` across many files can no longer leave a half-applied state — it's all-or-nothing (issue #1's COW slice 2). Single-file writes were already atomic, so this is the only batch that needed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1 slice 2 — COW batch atomicity.
apply_corrections(thecorrect --applybatch, the only true multi-file write) is now all-or-nothing: phase 1 computes every change in memory, phase 2 writes them, and on any write failure the files already written are restored from their in-memory originals before re-raising. A bulk correction across many files can no longer leave a half-applied state (the issue's exact pain). Snapshot-rollback approach (approved over temp-tree swap). TDD: injected mid-batch write failure → all files restored; happy path → all changed. ruff + mypy + bandit clean. Follow-up: a graceful CLI message on the (rare) rollback path.