fix(correct): graceful message when a batch correction rolls back (refs #1)#33
Merged
Conversation
#1) When apply_corrections rolls a failed batch back (COW atomicity), the correct command now reports a clean "correction failed and was rolled back — no files were changed" instead of surfacing an uncaught OSError traceback. The data was already safe; this just makes the rare failure path user-friendly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish for the COW rollback path (#1). When a batch
correct --applyfails mid-write, apply_corrections already restores all files (all-or-nothing); this makes the CLI report a clean "correction failed and was rolled back — no files were changed" instead of an uncaught OSError traceback. Test: mocked OSError from correct_term → exit 1 + graceful message. ruff + mypy clean.